1   ////////////////////////////////////////////////////////////////////////////////
2   // checkstyle: Checks Java source code for adherence to a set of rules.
3   // Copyright (C) 2001-2019 the original author or authors.
4   //
5   // This library is free software; you can redistribute it and/or
6   // modify it under the terms of the GNU Lesser General Public
7   // License as published by the Free Software Foundation; either
8   // version 2.1 of the License, or (at your option) any later version.
9   //
10  // This library is distributed in the hope that it will be useful,
11  // but WITHOUT ANY WARRANTY; without even the implied warranty of
12  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
13  // Lesser General Public License for more details.
14  //
15  // You should have received a copy of the GNU Lesser General Public
16  // License along with this library; if not, write to the Free Software
17  // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18  ////////////////////////////////////////////////////////////////////////////////
19  
20  package com.puppycrawl.tools.checkstyle.checks.imports;
21  
22  import java.util.HashSet;
23  import java.util.Set;
24  
25  import com.puppycrawl.tools.checkstyle.FileStatefulCheck;
26  import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
27  import com.puppycrawl.tools.checkstyle.api.DetailAST;
28  import com.puppycrawl.tools.checkstyle.api.FullIdent;
29  import com.puppycrawl.tools.checkstyle.api.TokenTypes;
30  
31  /**
32   * <p>
33   * Checks for imports that are redundant. An import statement is
34   * considered redundant if:
35   * </p>
36   *<ul>
37   *  <li>It is a duplicate of another import. This is, when a class is imported
38   *  more than once.</li>
39   *  <li>The class non-statically imported is from the {@code java.lang}
40   *  package. For example importing {@code java.lang.String}.</li>
41   *  <li>The class non-statically imported is from the same package as the
42   *  current package.</li>
43   *</ul>
44   * <p>
45   * An example of how to configure the check is:
46   * </p>
47   * <pre>
48   * &lt;module name="RedundantImport"/&gt;
49   * </pre>
50   * Compatible with Java 1.5 source.
51   *
52   */
53  @FileStatefulCheck
54  public class RedundantImportCheck
55      extends AbstractCheck {
56  
57      /**
58       * A key is pointing to the warning message text in "messages.properties"
59       * file.
60       */
61      public static final String MSG_LANG = "import.lang";
62  
63      /**
64       * A key is pointing to the warning message text in "messages.properties"
65       * file.
66       */
67      public static final String MSG_SAME = "import.same";
68  
69      /**
70       * A key is pointing to the warning message text in "messages.properties"
71       * file.
72       */
73      public static final String MSG_DUPLICATE = "import.duplicate";
74  
75      /** Set of the imports. */
76      private final Set<FullIdent> imports = new HashSet<>();
77      /** Set of static imports. */
78      private final Set<FullIdent> staticImports = new HashSet<>();
79  
80      /** Name of package in file. */
81      private String pkgName;
82  
83      @Override
84      public void beginTree(DetailAST aRootAST) {
85          pkgName = null;
86          imports.clear();
87          staticImports.clear();
88      }
89  
90      @Override
91      public int[] getDefaultTokens() {
92          return getRequiredTokens();
93      }
94  
95      @Override
96      public int[] getAcceptableTokens() {
97          return getRequiredTokens();
98      }
99  
100     @Override
101     public int[] getRequiredTokens() {
102         return new int[] {
103             TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, TokenTypes.PACKAGE_DEF,
104         };
105     }
106 
107     @Override
108     public void visitToken(DetailAST ast) {
109         if (ast.getType() == TokenTypes.PACKAGE_DEF) {
110             pkgName = FullIdent.createFullIdent(
111                     ast.getLastChild().getPreviousSibling()).getText();
112         }
113         else if (ast.getType() == TokenTypes.IMPORT) {
114             final FullIdent imp = FullIdent.createFullIdentBelow(ast);
115             if (isFromPackage(imp.getText(), "java.lang")) {
116                 log(ast, MSG_LANG, imp.getText());
117             }
118             // imports from unnamed package are not allowed,
119             // so we are checking SAME rule only for named packages
120             else if (pkgName != null && isFromPackage(imp.getText(), pkgName)) {
121                 log(ast, MSG_SAME, imp.getText());
122             }
123             // Check for a duplicate import
124             imports.stream().filter(full -> imp.getText().equals(full.getText()))
125                 .forEach(full -> log(ast,
126                     MSG_DUPLICATE, full.getLineNo(),
127                     imp.getText()));
128 
129             imports.add(imp);
130         }
131         else {
132             // Check for a duplicate static import
133             final FullIdent imp =
134                 FullIdent.createFullIdent(
135                     ast.getLastChild().getPreviousSibling());
136             staticImports.stream().filter(full -> imp.getText().equals(full.getText()))
137                 .forEach(full -> log(ast,
138                     MSG_DUPLICATE, full.getLineNo(), imp.getText()));
139 
140             staticImports.add(imp);
141         }
142     }
143 
144     /**
145      * Determines if an import statement is for types from a specified package.
146      * @param importName the import name
147      * @param pkg the package name
148      * @return whether from the package
149      */
150     private static boolean isFromPackage(String importName, String pkg) {
151         // imports from unnamed package are not allowed:
152         // https://docs.oracle.com/javase/specs/jls/se7/html/jls-7.html#jls-7.5
153         // So '.' must be present in member name and we are not checking for it
154         final int index = importName.lastIndexOf('.');
155         final String front = importName.substring(0, index);
156         return front.equals(pkg);
157     }
158 
159 }